Improve error handling and messages in BaseArray#281
Improve error handling and messages in BaseArray#281OriolAbril merged 2 commits intoarviz-devs:mainfrom
Conversation
Documentation build overview
Show files changed (11 files in total): 📝 11 modified | ➕ 0 added | ➖ 0 deleted
|
OriolAbril
left a comment
OriolAbril
left a comment
There was a problem hiding this comment.
The PR title is extremely scary, luckily the actual changes have nothing to do with it or with the PR description. Please update it.
Clearer error messages is usually a good idea
src/arviz_stats/base/array.py
Outdated
| if range.shape[:-1] != broadcased_shape: | ||
| raise ValueError( | ||
| "`range` has incompatible shape. " | ||
| f"Expected shape (*, 2) with leading dimensions {broadcased_shape}, " |
There was a problem hiding this comment.
we can build the whole expected shape here so it is clearer instead of the *, 2 then showing the leading dimensions
ShivamRajSri
changed the title
|
Sorry for the delayed response @OriolAbril I completely missed your comment last week. |
OriolAbril
force-pushed
the
refactor-array-axis-handling
branch
from
3c7439e to
8ea6967
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
- Coverage 84.50% 84.42% -0.09%
==========================================
Files 42 42
Lines 5823 5829 +6
==========================================
Hits 4921 4921
- Misses 902 908 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
This PR replaces a couple of internal assert statements in BaseArray with explicit ValueError checks and clearer error messages.
The goal is to make the validation more robust (since assert can be disabled in optimized runs) and to provide more informative errors to users when inputs have incompatible shapes or axes.
There are no functional changes — just safer validation and clearer error handling.